Fixed node controller assignemnts update after pods restart #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a storage node restarts and its IP stop responding, the coordinator health check will detect it in a ~2seconds period, though the component that sends the cluster assignements updates will not detect the issue.
One of the reason is that it's using a grpc stream, so there is no timeout on the send operation (because it would apply to the lifetime of the stream itself, which instead needs to be long-lived).
The storage servers need to receive the new cluster assignments after restart, otherwise they cannot pass it back to their clients.
To fix the issue, we close the assignments stream whenever the health-check failure is triggered. This will ensure that coordinator will retry after the restart.