Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

add metrics for offset commit #519

Merged
merged 4 commits into from
May 20, 2021
Merged

add metrics for offset commit #519

merged 4 commits into from
May 20, 2021

Conversation

hangc0276
Copy link
Collaborator

Modification

  1. add metrics for coordinator and offsetAcker
  2. fix metrics provider bug

@hangc0276 hangc0276 self-assigned this May 19, 2021
@BewareMyPower
Copy link
Collaborator

Please fix the Codacy check first.

aloyszhang
aloyszhang approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BewareMyPower BewareMyPower merged commit e86d8e8 into streamnative:master May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aloyszhang aloyszhang aloyszhang approved these changes

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@jiazhai jiazhai Awaiting requested review from jiazhai

@wuzhanpeng wuzhanpeng Awaiting requested review from wuzhanpeng

Assignees

@hangc0276 hangc0276

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hangc0276 @BewareMyPower @aloyszhang