This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There're some problems with produce performance.
The main problem is the pending produce queue. It holds multiple pending produce requests (
PendingProduce
), which wait untilPersistentTopic
is ready and theMemoryRecords
is encoded. First,PendingProduce
s wait for different futures ofPersistentTopic
. Second, encodingMemoryRecords
is fast so that putting it to another thread is not necessary and could cause some performance overhead.Modifications
MemoryRecords
in the same thread ofhandleProduceRequest
.CompletableFuture<PersistentTopic>
is done.CompletableFuture<PersistentTopic>
. This trick is performed byPendingTopicFutures
, which uses the previousCompletableFuture<PersistentTopic>
bythenApply
orexceptionally
.PendingTopicFutures
.handleProduceRequest
.