This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#429 introduced a request timeout to avoid some requests being blocked by the previous requests. However, it changes the behavior of
writeAndFlushResponseToClient
.Before #429,
writeAndFlushResponseToClient
removed all completed response futures in the head ofresponseQueue
and then sent the completed response to client.After #429,
writeAndFlushResponseToClient
removed all response futures, and useCompletableFuture#get(long timeout, TimeUnit unit)
to wait until all futures are completed or expired.We shouldn't wait any
CompletableFuture
in aCompletableFuture
's callback.Modifications
In
writeAndFlushResponseToClient
, only remove completed or expired response futures. Here we combinepeek
andboolean remove(Object o)
for thread safety.For responses that are expired or completed exceptionally, just skip them and don't send any response to client because Kafka client has a retry mechanism. When Kafka processes an expired request, it also doesn't send any response to client.
For responses that are completed normally, send the response and release the internal Netty buffers if necessary.