This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Add inner topic protection #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a doubt about your TODO: do we need to protect consuming? If I didn't remember wrong, Kafka allows consumers to read |
OK, the consume may expose to users. |
BewareMyPower
suggested changes
Apr 22, 2021
tests/src/test/java/io/streamnative/pulsar/handlers/kop/InnerTopicProtectionTest.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/io/streamnative/pulsar/handlers/kop/InnerTopicProtectionTest.java
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/PendingProduce.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Apr 23, 2021
tests/src/test/java/io/streamnative/pulsar/handlers/kop/InnerTopicProtectionTest.java
Show resolved
Hide resolved
|
I see it works well with system topic enabled. Is apache/pulsar#10341 necessary? |
|
Sorry I just misunderstood. |
BewareMyPower
approved these changes
Apr 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For inner topic, such as, __consumer_offsets, __transaction_stats, and system topic, such as, __change_event, they are expose to all users and can produce / consumer message to / from those topic, which will cause the cluster crash.
Changes
TODO