This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Fix AdminManager memory leak #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dockerzhang
approved these changes
Apr 12, 2021
jiazhai
approved these changes
Apr 12, 2021
BewareMyPower
added a commit
to BewareMyPower/kop
that referenced
this pull request
Apr 12, 2021
Fixes streamnative#322 The `DelayedOperationPurgatory` field of `AdminManager` will never be closed, so the `ShutdownableThread` would be started each time a request handler is created and won't be stopped.
BewareMyPower
added a commit
that referenced
this pull request
Apr 12, 2021
BewareMyPower
added a commit
to BewareMyPower/kop
that referenced
this pull request
Apr 14, 2021
Fixes streamnative#322 The `DelayedOperationPurgatory` field of `AdminManager` will never be closed, so the `ShutdownableThread` would be started each time a request handler is created and won't be stopped.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #322
The
DelayedOperationPurgatoryfield ofAdminManagerwill never be closed, so theShutdownableThreadwould be started each time a request handler is created and won't be stopped.