This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
change pulsar dependency jars to provided scope to reduce nar package size #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Mar 3, 2021
BewareMyPower
pushed a commit
that referenced
this pull request
Mar 3, 2021
… size (#391) ### Motivation KOP put pulsar dependency jar into nar package, which lead the nar size up to 130MB. However, the kop nar run with pulsar broker, the pulsar dependency is no need to be packed into KOP nar package. ### Changes 1. change pulsar dependency jar scope to provided in pom.xml
josephglanville
added a commit
to josephglanville/aop
that referenced
this pull request
Apr 25, 2021
Similar to streamnative/kop#391 and streamnative/mop#53 the purpose of this change is to reduce the archive size as these dependencies will be provided on the class path at runtime.
josephglanville
added a commit
to josephglanville/aop
that referenced
this pull request
Apr 26, 2021
Similar to streamnative/kop#391 and streamnative/mop#53 the purpose of this change is to reduce the archive size as these dependencies will be provided on the class path at runtime.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
KOP put pulsar dependency jar into nar package, which lead the nar size up to 130MB. However, the kop nar run with pulsar broker, the pulsar dependency is no need to be packed into KOP nar package.
Changes