This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[Transaction] KoP transaction stage0 #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
gaoran10
force-pushed
the
kop-transaction-stage0
branch
2 times, most recently
from
9ccfb87 to
6e812c1
Compare
|
@gaoran10 Please help on the conflicts. |
jiazhai
approved these changes
Jan 13, 2021
|
@gaoran10 Please help on the conflicts. |
gaoran10
force-pushed
the
kop-transaction-stage0
branch
2 times, most recently
from
bb3125f to
a2ffa5a
Compare
2. fix transaction test
gaoran10
force-pushed
the
kop-transaction-stage0
branch
from
2ce07b4 to
7c8d965
Compare
BewareMyPower
suggested changes
Jan 20, 2021
tests/src/test/java/io/streamnative/pulsar/handlers/kop/TransactionTest.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Jan 20, 2021
tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaApisTest.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Jan 20, 2021
tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaIntegrationTest.java
Show resolved
Hide resolved
BewareMyPower
suggested changes
Jan 20, 2021
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/format/KafkaEntryFormatter.java
Outdated
Show resolved
Hide resolved
|
I've left some comments, PTAL. |
BewareMyPower
approved these changes
Jan 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master issue https://github.com/streamnative/platform-epics/issues/169
Task issue #39
Motivation
KoP transaction stage0.
This PR initialized some classes for the KoP transaction.
Make the basic publish and dispatch transaction messages process pass.