This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
remove unnecessary topics cache for Topic Manager #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dockerzhang
force-pushed
the
remove-topics-cache
branch
2 times, most recently
from
0830650 to
441fa83
Compare
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaTopicManager.java
Show resolved
Hide resolved
|
@dockerzhang Thanks for the change. Would you please help add the dedicated test cases to test the new code path? |
dockerzhang
force-pushed
the
remove-topics-cache
branch
from
441fa83 to
6e1594f
Compare
|
@jiazhai there is existed |
dockerzhang
force-pushed
the
remove-topics-cache
branch
from
6e1594f to
a50ace5
Compare
BewareMyPower
suggested changes
Dec 18, 2020
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaTopicManager.java
Outdated
Show resolved
Hide resolved
dockerzhang
force-pushed
the
remove-topics-cache
branch
from
dcf5a1d to
b8f2b30
Compare
BewareMyPower
approved these changes
Dec 18, 2020
|
LGTM. PTAL again @jiazhai |
BewareMyPower
pushed a commit
that referenced
this pull request
Jan 15, 2021
fixes #266 `topics` in `KafkaTopicManager` will cache `PersistentTopic` by `brokerService.getTopic`, it's unnecessary because `PersistentTopic` is cached in `brokerService.getTopic`. we should remove it to avoid getting a `null` topic.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #266
topicsinKafkaTopicManagerwill cachePersistentTopicbybrokerService.getTopic, it's unnecessary becausePersistentTopicis cached inbrokerService.getTopic. we should remove it to avoid getting anulltopic.