This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 138
Added a new MetadataUtils with an implementation of createKafkaMetadataIfMissing… #168
Merged
jiazhai
merged 2 commits into
streamnative:master
from
wmccarley:fix-167-overwrite-cluster-metadata
Aug 18, 2020
Merged
Added a new MetadataUtils with an implementation of createKafkaMetadataIfMissing… #168
jiazhai
merged 2 commits into
streamnative:master
from
wmccarley:fix-167-overwrite-cluster-metadata
Aug 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taIfMissing that coes not overwrite the cluster metadata. Modified several use cases to support the change. Logic for the createKafkaMetadataIfMissing implementation is as follows: - If the tenant does not exist it will be created - If the tenant exists but the allowedClusters list does not include the cluster this method will add the cluster to the allowedClusters list - If the namespace does not exist it will be created - If the namespace exists but the replicationClusters list does not include the cluster this method will add the cluster to the replicationClusters list - If the offset topic does not exist it will be created - If the offset topic exists but some partitions are missing, the missing partitions will be created
node-rdkafka fails KafkaIntegrationTest on my machine with: java.lang.IllegalArgumentException: Invalid version for API key API_VERSIONS: 3 I suspect this is also where it is failing in github actions but not sure because I can't see the logs. Any help fixing this would be nice, I can't figure out how this change could have introduced this bug....... |
@wmccarley from the log(https://github.com/streamnative/kop/pull/168/checks?check_run_id=942014543), it looks like a container issue, I will re-trigger it.
|
jiazhai
approved these changes
Aug 18, 2020
josephglanville
added a commit
to josephglanville/kop
that referenced
this pull request
Apr 18, 2021
This case is usually encountered when attempting to use KoP with standalone mode. When new behavior was introduced in streamnative#168 standalone mode was broken due to sample namespace setup etc not taking place until after the broker is initalised (which in turn initialises protocol handlers). Fixes streamnative#185
josephglanville
added a commit
to josephglanville/kop
that referenced
this pull request
Apr 18, 2021
This case is usually encountered when attempting to use KoP with standalone mode. When new behavior was introduced in streamnative#168 standalone mode was broken due to sample namespace setup etc not taking place until after the broker is initalised (which in turn initialises protocol handlers). Fixes streamnative#185
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…that does not overwrite the cluster metadata. Modified several use cases to support the change.
Logic for the createKafkaMetadataIfMissing implementation is as follows: