Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support init jwt secret when create pulsar cluster #1072

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Jul 21, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

  • In order to reuse toolset image and to make it easier to manage, we put this tool under toolset, which will share most of toolset's functionality(image, securityContext, label etc.)
  • No extra configuration is introduced, when jwt auth is enabled, it will execute the job if initialize is configured.
  • Multiple executions will not overwrite an existing secret

One example:

helm install {your-release-name} ./ -f ./values.yaml --set initialize=true --set namespace={your-namespace} --set components.vault=false --set components.streamnative_console=false --set monitoring.node_exporter=false --set auth.vault.enabled=false --set auth.authentication.jwt.enabled=true -n {your-namespace} --debug

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@tuteng tuteng requested review from a team, sijie and addisonj as code owners July 21, 2023 11:12
@github-actions
Copy link

@tuteng:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jul 21, 2023
@tuteng tuteng requested review from a team, fantapsody, ericsyh and ciiiii July 21, 2023 11:20
@ericsyh ericsyh added this to the sn-platform-1.11 milestone Jul 25, 2023
@github-actions
Copy link

@tuteng:Thanks for providing doc info!

@github-actions github-actions bot added doc This pr contains a document and removed doc-info-missing This pr needs to mark a document option in description labels Jul 25, 2023
@ericsyh ericsyh added doc-required This pr needs a document and removed doc This pr contains a document labels Jul 25, 2023
@tuteng tuteng force-pushed the fixed/support-init-jwt-secret branch from 30c8227 to 95d0f01 Compare July 28, 2023 03:58
@ericsyh ericsyh merged commit eebdd32 into master Jul 31, 2023
@ericsyh ericsyh deleted the fixed/support-init-jwt-secret branch July 31, 2023 06:07
ericsyh pushed a commit that referenced this pull request Jul 31, 2023
* Support init jwt secret when create pulsar cluster

* Fixed jwt secret config

* Update sn platform slim

(cherry picked from commit eebdd32)
ericsyh pushed a commit that referenced this pull request Jul 31, 2023
* Support init jwt secret when create pulsar cluster

* Fixed jwt secret config

* Update sn platform slim

(cherry picked from commit eebdd32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants