Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sn-platform][sn-platform-slim] Add if statement for customWorkerConfig #1038

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

jiangpengcheng
Copy link
Member

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

PulsarBroker doesn't allow empty value for spec.config.function.customWorkerConfig, so only pass it when it's not empty

Modifications

Add if statement to the broker.functionmesh.customWorkerConfig

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@jiangpengcheng jiangpengcheng requested review from a team, sijie and addisonj as code owners June 13, 2023 07:02
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jun 13, 2023
@ericsyh ericsyh added this to the sn-platform-1.10.3 milestone Jun 14, 2023
@ericsyh ericsyh merged commit c968e02 into master Jun 14, 2023
@ericsyh ericsyh deleted the fix_function_custom_worker_config branch June 14, 2023 01:24
ericsyh pushed a commit that referenced this pull request Jun 14, 2023
ericsyh pushed a commit that referenced this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants