Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor enums to const #108

Merged
merged 13 commits into from
Oct 29, 2024
Merged

fix: refactor enums to const #108

merged 13 commits into from
Oct 29, 2024

Conversation

littlespex
Copy link
Collaborator

@littlespex littlespex commented Oct 26, 2024 •
edited
Loading

see: #103

@littlespex
chore: update eslint
a47a014 
- update deps
- update rules
- reformat code base

Signed-off-by: Casey Occhialini <[email protected]>
@littlespex
- rename IMapper
1d6b9d1 
Signed-off-by: Casey Occhialini <[email protected]>
@littlespex littlespex requested review from a team as code owners October 26, 2024 03:16
@littlespex
fix: refactor enums to const
601e671 
see: #103
Signed-off-by: Casey Occhialini <[email protected]>
@littlespex
chore: update api docs
d4f815e 
Signed-off-by: Casey Occhialini <[email protected]>
@littlespex
no message
767fc84 
Signed-off-by: Casey Occhialini <[email protected]>
@littlespex
chore: add comment to tsconfig isolatedDeclarations property
52558dd 
Signed-off-by: Casey Occhialini <[email protected]>
@littlespex
chore: remove redundant as const
6c03ab0 
Signed-off-by: Casey Occhialini <[email protected]>
@littlespex
chore: add ValueOf helper type
5f25bab 
Signed-off-by: Casey Occhialini <[email protected]>
@littlespex
no message
c170adf 
Signed-off-by: Casey Occhialini <[email protected]>
Beraliv
Beraliv reviewed Oct 28, 2024
View reviewed changes
Copy link

@Beraliv Beraliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments, LGTM! (However, I cannot approve as I don't have rights)

@cjpillsbury
Copy link

Same on both counts.

Base automatically changed from task/update-eslint to main October 28, 2024 18:25
@littlespex
Merge branch 'main' into issue/enum-to-const
d2e88b1 
Signed-off-by: Casey Occhialini <[email protected]>
@littlespex
no message
8250576 
Signed-off-by: Casey Occhialini <[email protected]>
@littlespex
no message
f9683fe 
Signed-off-by: Casey Occhialini <[email protected]>
@littlespex
no message
3b89ff2 
Signed-off-by: Casey Occhialini <[email protected]>
Beraliv
Beraliv approved these changes Oct 29, 2024
View reviewed changes
Copy link

@Beraliv Beraliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last question about CMCD_JSON as typeof CMCD_JSON, otherwise LGTM!

@littlespex littlespex merged commit 98649c7 into main Oct 29, 2024
2 checks passed
@littlespex littlespex deleted the issue/enum-to-const branch October 29, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beraliv Beraliv Beraliv approved these changes

@cjpillsbury cjpillsbury Awaiting requested review from cjpillsbury

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littlespex @cjpillsbury @Beraliv