remove magic numbers + remove _

lib/src/id3/getId3Frames.ts

@@ -6,6 +6,9 @@ import { isId3Footer } from './util/isId3Footer.js';
 import { isId3Header } from './util/isId3Header.js';
 import { readId3Size } from './util/readId3Size.js';
 
+const HEADER_FOOTER_SIZE = 10;
+const FRAME_SIZE = 10;
+
 /**
  * Returns an array of ID3 frames found in all the ID3 tags in the id3Data
  *
@@ -24,10 +27,10 @@ export function getId3Frames(id3Data: Uint8Array): Id3Frame[] {
 	while (isId3Header(id3Data, offset)) {
 		const size = readId3Size(id3Data, offset + 6);
 		// skip past ID3 header
-		offset += 10;
+		offset += HEADER_FOOTER_SIZE;
 		const end = offset + size;
 		// loop through frames in the ID3 tag
-		while (offset + 8 < end) {
+		while (offset + FRAME_SIZE < end) {
 			const frameData: RawId3Frame = getId3FrameData(id3Data.subarray(offset));
 			const frame: Id3Frame | undefined = decodeId3Frame(frameData);
 			if (frame) {
@@ -39,7 +42,7 @@ export function getId3Frames(id3Data: Uint8Array): Id3Frame[] {
 		}
 
 		if (isId3Footer(id3Data, offset)) {
-			offset += 10;
+			offset += HEADER_FOOTER_SIZE;
 		}
 	}
 

lib/test/structuredfield/decodeId3TextFrame.test.ts

@@ -8,7 +8,7 @@ describe('decodeId3TextFrame', () => {
 		const frame = {
 			type: 'TXXX',
 			data: new Uint8Array([0, 102, 111, 111, 0, 97, 98, 99]),
-			size: 2, // required by the _decodeTextFrame function
+			size: 2, // required by the decodeTextFrame function
 		};
 
 		const testables = {