Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Accents in Dashboard Search cause issues #799

Closed
Ircas opened this issue May 19, 2019 · 5 comments
Closed

Bug: Accents in Dashboard Search cause issues #799

Ircas opened this issue May 19, 2019 · 5 comments
Labels
Milestone

Comments

@Ircas
Copy link

Ircas commented May 19, 2019

It seems that search needs some sort of Enhancement or Bug Fix I don't really know.
So this might not affect the 90% of users of streama but I think it's a big deal for non english languages.

Issue:
When a title from an imported video has accents like ( š ά é ñ í ü ï ) you have to search using the accent, if not no results show up.

How it should work
When using other searches lets say directly in sql (phpmyadmin) it doesnt matter if you use accents or not the results will come up.
Lets say we search for Jörn it doesnt matter if we search for Jörn or Jorn it will come up as the same.

Possible solutions - Helpfull Links
Search should match accented characters (those with diacritical marks).
I have searched the internet and found a bunch of stuff that might be helpfull.

-- This is called Accent Folding in autocomplete (jQuery).
https://jqueryui.com/autocomplete/#folding

-- Following a very nice article with code about this.
http://alistapart.com/article/accent-folding-for-auto-complete/

-- Here is an actual fiddle on how this should work
http://jsfiddle.net/cps7/3R5B2/7/

-- Finally this is a website you can use (type) and see all accented letters from 25+ languages
https://czech.typeit.org/

P.S. If you have time to look into this It would be really nice for a further Enhancement in search. The idea is simple. Just GET the original title from TMDB API and store it in the database.
So when you either search with your "localized" title or the original one the video will show up in both cases.

@dularion
Copy link
Member

dularion commented May 19, 2019

Could you give me an example of a name with an accent?

Edit: i figured out an example. Εκδικητές: Η Τελευταία Πράξη (2019) is the greek name for the latest avengers. If you use the dashboard top search and type εκδικητες without the accented έ then you find nothing. if you however use the smaller movie-search within the discover-movies section, it works fine:

image

I'll investigate further

@dularion dularion added the Bug label May 19, 2019
@dularion dularion changed the title [Feature request] Universal Search Bug: Accents in Dashboard Search cause issues May 19, 2019
dularion pushed a commit that referenced this issue May 19, 2019
@dularion dularion added this to the 1.7 milestone May 19, 2019
@dularion
Copy link
Member

Ok, the main issue is fixed in 1.7.0-RC8. For the addition at the end, please open a separate feature request :)

@Ircas
Copy link
Author

Ircas commented May 19, 2019

Any localized movie when using other language from TMDB lets say :

https://www.themoviedb.org/movie/15383-l-arm-e-des-ombres

Original title is L'Armée des ombres (with an accent e)
English title is Army of Shadows

An other example

https://www.themoviedb.org/movie/120-the-lord-of-the-rings-the-fellowship-of-the-ring?language=en-US

English title
The Lord of the Rings: The Fellowship of the Ring

Thats the title in Hungary
A Gyűrűk Ura: A gyűrű szövetsége

If I am using a TMDB other than english that has accented letter it imports if possible the localized title.

If you start searching you have to add every accent for the movie to show up as a result.

By grabbing and storing both original title and localized one then edit the search to match accented letters on both video titl it would not matter how you search the movie it would alway show up.

@dularion
Copy link
Member

as i said, already fixed in RC8 :) see https://github.com/streamaserver/streama/releases/tag/v1.7.0-RC8

@Ircas
Copy link
Author

Ircas commented May 19, 2019

Sorry was too let on reply I will check the update then I will ask you to Mark as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants