Add support for tvOS, watchOS and visionOS #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopopolo
requested changes
Jan 28, 2025
Kijewski
approved these changes
Jan 28, 2025
|
Btw, I chose the name |
lopopolo
approved these changes
Feb 2, 2025
|
Pulling in #148 once it lands should get most of the builds passing. |
lopopolo
added a commit
to artichoke/artichoke
that referenced
this pull request
Feb 2, 2025
By using `target_vendor = "apple"` instead of `target_os = "macos"`. The implementation uses APIs from `libSystem` which is available on all Apple platforms that Rust supports. Inpsired by strawlab/iana-time-zone#146. This is technically a breaking change on non-macOS Apple targets, so bump the crate version to 2.0.0.
|
@madsmtm if you can rebase and resolve conflicts we can get this merged |
|
Hmm, I've rebased, but the CI didn't seem to run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
target_vendor = "apple"instead ofany(target_os = "macos", target_os = "ios")- the implementation uses CoreFoundation functions which are available on all Apple platforms.Fixes #71.