-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Annotated + strawberry.lazy + deferred annotations #3507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bellini666 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Thanks for adding the Here's a preview of the changelog: This release fixes an issue when using from __future__ import annotations
import strawberry
from typing import Annotated
@strawberry.type
class Query:
a: Annotated["datetime", strawberry.lazy("datetime")]
schema = strawberry.Schema(Query) Before this would only work if Here's the tweet text:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3507 +/- ##
=======================================
Coverage 96.51% 96.51%
=======================================
Files 511 511
Lines 32965 32973 +8
Branches 5482 5484 +2
=======================================
+ Hits 31815 31825 +10
+ Misses 917 915 -2
Partials 233 233 |
bbd1870
to
f960901
Compare
CodSpeed Performance ReportMerging #3507 will not alter performanceComparing Summary
|
🔥 |
f960901
to
89efe33
Compare
for more information, see https://pre-commit.ci
Fix #3491