Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pool port to URL example. #78

Merged
merged 2 commits into from
May 28, 2024
Merged

Add pool port to URL example. #78

merged 2 commits into from
May 28, 2024

Conversation

b-rowan
Copy link
Contributor

@b-rowan b-rowan commented May 18, 2024

Adds a port to the pool URL example.

Curious if there is an expected default port? I haven't seen one anywhere, but it might be a good idea to specify it here if it exists, or maybe define one if not.

@plebhash
Copy link
Contributor

I think standardizing ports for roles is a good idea. But I don't think it makes sense to standardize that by changing this specific file.

I wrote a more concrete suggestion here: #79

@b-rowan
Copy link
Contributor Author

b-rowan commented May 21, 2024

Agreed, maybe not the spot for a concrete "default", but I think the core PR still remains, I believe it's a good idea to demonstrate usage with a port, as more than likely the pool URL will need to have a port specified.

04-Protocol-Security.md Outdated Show resolved Hide resolved
@plebhash
Copy link
Contributor

Agreed, maybe not the spot for a concrete "default", but I think the core PR still remains, I believe it's a good idea to demonstrate usage with a port, as more than likely the pool URL will need to have a port specified.

makes sense!

I suggest we switch to port 34254, that's the one we are using on StratumV2 Reference Implementation

@pavlenex pavlenex requested a review from Fi3 May 21, 2024 19:10
@pavlenex
Copy link
Contributor

Leaving up to @Fi3 and @jakubtrnka to review and decide if this is okay in specs.

@Fi3 Fi3 merged commit c1d108a into stratum-mining:main May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants