-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge case testing, boundary testing, negative testing http analyzer #516
base: develop
Are you sure you want to change the base?
Edge case testing, boundary testing, negative testing http analyzer #516
Conversation
Hello @zeyadtmi Thanks for your PR, i'm currently reviewing it However i have one small comment When you open 2 new PRs, each PR should be separated and based on the origin/develop instead of your local develop or any other branch I see what you did here is, made the first threat_intel PR in a branch, opened a PR, then on the same branch, you added the http tests and then opened another PR The issue in what you did is, if your first PR failed, your second PR will fail too because the changes you did in the first one is also there in the second one |
Also the tests/test_http_analyzer.py::test_check_suspicious_user_agents_parametrized test failed. so i suggest you always test your PR locally before opening a PR in any repo. I will re-review your PR once you fix it and post a screenshot of all tests passing locally Thanks for your effort! |
Fixes Issue
Closes #515
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers