-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more tests to test_horizontal_portscans.py #507
Conversation
…ions for debugging
…he parent domain for faster matching
…whitelists_evidence_from_interface Fix whitelists evidence from interface and whitelist alerts to all orgs by default
…' into alya/use-the-new-slips-threshold
…the-new-slips-threshold Change the default slips evidence detection threshold
Hello @Sekhar-Kumar-Dash Very nice work you've done there, thank you! However i have one small comment, i saw many duplicate functions in your PR, i recommend you check those before your future PRs Thanks for the hard work! Keep it up. |
Hi @AlyaGomaa Thank you so much for reviewing my PR and for making the corrections. Sorry for the duplicate functions, I will check that out |
You're welcome!:) |
Fixes Issue #511
Changes proposed
With this pull request, I have added more tests to test_horizontal_portscans.py, which will improve the code coverage
Check List