Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate data and raise exception #78

Merged

Conversation

verovaleros
Copy link
Member

Description

This PR fixes a bug in which the Alpha and Alpha7 models will report success even when there's no data available to run the models.

  • The Alpha model was modified to validate that the attack cache is not empty before attempting to build the blocklist.
  • An exception is now raised if the attack cache is empty so the run_model will report the exception instead of success.

Fixes #66

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Changes to the documentation

  • I have made corresponding changes to the documentation

@verovaleros verovaleros added the enhancement New feature or request label Nov 12, 2024
@verovaleros verovaleros added this to the v3.1.0 milestone Nov 12, 2024
@verovaleros verovaleros self-assigned this Nov 12, 2024
@verovaleros verovaleros merged commit 34db498 into development Nov 12, 2024
3 checks passed
@verovaleros verovaleros deleted the bugfix-alpha-success-when-no-data-is-available branch November 12, 2024 16:19
@verovaleros verovaleros linked an issue Nov 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Alpha(s) models report 'success' when no data is available
1 participant