Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor knowledge base and models #67

Merged
merged 19 commits into from
Nov 4, 2024

Conversation

verovaleros
Copy link
Member

@verovaleros verovaleros commented Nov 4, 2024

Description

This PR introduces some important changes:

  1. Each module was moved to its own file, with individual atomic logic.
  2. The Knowledge base logic was moved to its own file to decouple from prioritizer and rf models
  3. A new function _rebuild was added such that it can be called to rebuild the entire knowledge base from bin/aip
  4. A new option to call the rebuild process was added to bin/aip
  5. Logging was improved, making sure there are verbose and debug options, that are starting to be propagated through AIP to control the level of information.

closes #44
closes #47 (There is more work on logging to be done, but now, all prints are removed)

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Tested with multiple scenarios: existing, incomplete or empty knowledge base; run one model in the past; run all models in the past; run all models in the future; etc.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Changes to the documentation

  • I have made corresponding changes to the documentation

@verovaleros verovaleros added the enhancement New feature or request label Nov 4, 2024
@verovaleros verovaleros added this to the v3.1.0 milestone Nov 4, 2024
@verovaleros verovaleros self-assigned this Nov 4, 2024
@verovaleros verovaleros merged commit 8533535 into development Nov 4, 2024
3 checks passed
@verovaleros verovaleros deleted the refactor/knowledge-base-and-models branch November 4, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant