Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker file #35

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Update Docker file #35

merged 9 commits into from
Oct 21, 2024

Conversation

verovaleros
Copy link
Member

Description

This PR includes changes to etc/docker/Dockerfile and etc/docker/entrypoint.sh:

  • Optimises layering of the docker image
  • Updates base image to Python 3.12
  • Removes hardcoded paths
  • Updates Conda installation
  • Removes need of installing packages with apt in an attempt to reduce the size of the container

Fixes #34

How Has This Been Tested?

  • Image was rebuilt and AIP was run successfully on Zeek data
  • Resulting blocklists were generated without errors

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@verovaleros verovaleros added the enhancement New feature or request label Oct 21, 2024
@verovaleros verovaleros added this to the v3.0.0 milestone Oct 21, 2024
@verovaleros verovaleros self-assigned this Oct 21, 2024
@verovaleros verovaleros linked an issue Oct 21, 2024 that may be closed by this pull request
@verovaleros verovaleros merged commit f20aaa3 into development Oct 21, 2024
@verovaleros verovaleros deleted the aip-updates branch October 21, 2024 11:58
@verovaleros verovaleros mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update Dockerfile to use Python 3.12 as base image
1 participant