Allow user to expand pool if block device is expanded #906
Conversation
|
will fail stratisd tests. |
mulkieran
force-pushed
the
expand-block-size-2
branch
from
3ec39c1 to
a21c3ab
Compare
|
rebased. |
mulkieran
force-pushed
the
expand-block-size-2
branch
from
b88f48d to
d4922d2
Compare
|
rebased. |
Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
expand-block-size-2
branch
from
d4922d2 to
37e90b2
Compare
| @@ -120,12 +120,76 @@ def from_str(code_str): | |||
| ) | |||
|
|
|||
|
|
|||
| class PoolDeviceSizeChangeCode(IntEnum): | |||
There was a problem hiding this comment.
This is the only class in _error_codes that doesn't follow the Pool.*ErrorCode naming pattern (and also the only class to define an I(nfo) as well as W/E). PoolDeviceSizeChangeErrorCode is a bit of a mouthful at 29 chars. It stuck out a bit and I wondered if it might be confusing to come across the class name in isolation but I think I'm probably being nit-picky here :)
There was a problem hiding this comment.
it's the first code that includes an info possibility, so the name was chosen with that in mind. It might have been better to leave out "Error" from all the class names at the start, just to allow for future variability.
There was a problem hiding this comment.
Yep that makes sense, thanks! I Think that was the conclusion I was slowly coming to myself :-)
src/stratis_cli/_error_codes.py
Outdated
| @@ -120,12 +120,76 @@ def from_str(code_str): | |||
| ) | |||
|
|
|||
|
|
|||
| class PoolDeviceSizeChangeCode(IntEnum): | |||
| """ | |||
| Codes to extend if a device | |||
|
Filed an issue for the naming question with error codes: #920 |
Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
expand-block-size-2
branch
from
d7d2e21 to
7e09a9f
Compare
Related stratis-storage/project#50
Implements a new command:
stratis pool extend-dataand extends the output ofblockdev listandpool list.blockdev listshows the new size of the pool if different from the current in use-size.pool listdisplays an Alert on the pool, if different.Supercedes #901