Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug command to get filesystem metadata #1089

Merged

Conversation

mulkieran
Copy link
Member

No description provided.

@mulkieran mulkieran self-assigned this Jul 26, 2024
@mulkieran mulkieran force-pushed the debug-filesystem-metadata branch 4 times, most recently from 36bdc53 to dfc2108 Compare July 30, 2024 18:22
@mulkieran mulkieran force-pushed the debug-filesystem-metadata branch 2 times, most recently from a886c88 to c68e7d5 Compare July 31, 2024 18:19
@mulkieran mulkieran requested review from bmr-cymru and drckeefe July 31, 2024 18:52
@mulkieran
Copy link
Member Author

@drckeefe @bmr-cymru Please take a look and let me know if you feel satisfied w/ the command-line arguments for the get-metadata call.

@mulkieran mulkieran requested a review from jbaublitz August 1, 2024 14:44
@mulkieran
Copy link
Member Author

re-running checks to catch up with updates to stratisd PR

Copy link
Member

@jbaublitz jbaublitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be one change required due to the stratisd side.

Comment on lines 192 to 194
json_format_data = [
json.loads(chunk) for chunk in metadata.split("\n") if chunk != ""
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have to change if the stratisd side changes.

@mulkieran mulkieran force-pushed the debug-filesystem-metadata branch 2 times, most recently from 44fff7b to 4eef8d9 Compare August 2, 2024 13:33
@mulkieran mulkieran marked this pull request as ready for review August 2, 2024 13:34
@mulkieran
Copy link
Member Author

/packit build

@mulkieran mulkieran merged commit ee68eb1 into stratis-storage:master Aug 2, 2024
13 checks passed
@mulkieran mulkieran deleted the debug-filesystem-metadata branch August 2, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done (1)
Development

Successfully merging this pull request may close these issues.

4 participants