Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix to 0.14 #475

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Update nix to 0.14 #475

merged 1 commit into from
Jun 14, 2019

Conversation

cuviper
Copy link
Contributor

@cuviper cuviper commented Jun 4, 2019

This is needed to fix breaking changes in libc on arm and s390x.
See: nix-rust/nix#1055

This is needed to fix breaking changes in libc on arm and s390x.
See: nix-rust/nix#1055
@stratis-bot
Copy link

Test with Jenkins?

@mulkieran
Copy link
Member

ok to test

@mulkieran
Copy link
Member

mulkieran commented Jun 10, 2019

Right now, in order for stratisd to compile on Rawhide, there needs to be a new version of devicemapper-rs w/ this new requirement, AFAICT. Other notes: nix 0.14 requires libc 0.2.55. But to really fix things, stratisd should also require nix 0.14. The reason there is no outstanding PR for that change as well, is that it can be fixed in rawhide by just updating the spec file. Actually, I just missed it, somehow.

@cuviper
Copy link
Contributor Author

cuviper commented Jun 10, 2019

See stratis-storage/stratisd#1552

@mulkieran
Copy link
Member

See stratis-storage/stratisd#1552

Egad! Yes, I see it now.

@mulkieran mulkieran requested a review from bgurney-rh June 13, 2019 21:37
@mulkieran mulkieran merged commit 1b6ff16 into stratis-storage:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants