Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify sorting for relational fields in the Content Manager list view #2224

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

gurdiga
Copy link
Contributor

@gurdiga gurdiga commented Sep 19, 2024

What does it do?

Removes a few words that seem to cause confusion.

Why is it needed?

Because higher in that note it is said that “Only one field can be displayed per relational field.”

Related issue(s)/PR(s)

None.

Because higher in that note it is said that “Only one field can be displayed per relational field.”
Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 5:28pm

@strapi-cla
Copy link

strapi-cla commented Sep 19, 2024

CLA assistant check
All committers have signed the CLA.

@pwizla
Copy link
Collaborator

pwizla commented Sep 25, 2024

Hi @gurdiga!

Thank you for submitting this PR. Could you please elaborate on why you think this change is necessary and what you are trying to achieve?

I double-checked with engineers and what is currently described is expected, so at least this line shouldn't be changed in the documentation.

Here's a screenshot of what works:
Capture d’écran 2024-09-24 à 14 56 56

Or maybe is there another part of the documentation that you would like to be improved? 🤔

@pwizla pwizla self-assigned this Sep 25, 2024
@gurdiga
Copy link
Contributor Author

gurdiga commented Sep 25, 2024

Here is the place in documentation that I’m referring to:

Screenshot 2024-09-25 at 20 45 29

This Note refers to “Relational fields”, first some specificities, then some limitations. The first limitation says:

Sorting cannot be enabled for relational fields which display several fields.

…which seems to imply that there can be relational fields which display several fields, while the first specificity says they can’t.

Maybe I’m misreading it. 🤔

@pwizla
Copy link
Collaborator

pwizla commented Sep 25, 2024

Hmm I see. This is not entirely clear for me either to be honest, so I'll dig deeper, test things further, and come back to you a.s.a.p.

@pwizla
Copy link
Collaborator

pwizla commented Sep 27, 2024

(still trying to figure out how it works and reproducing it, I'll keep you posted next week)

@pwizla
Copy link
Collaborator

pwizla commented Oct 4, 2024

Finally getting back to you.

I can't figure out why the "Sorting cannot be enabled for relational fields which display several fields." was written in the first place. It doesn't seem like it works this way, in Strapi 5 at least.

However, updating docs as you suggest would also be wrong because you can sort by relational fields, as shown in the screenshot.

So I think the docs should be updated as I suggest in my comments, actually deleting the first limitation entirely and rewriting the sentences above to simplify this.

Would that be OK for you?

@gurdiga
Copy link
Contributor Author

gurdiga commented Oct 4, 2024

Would that be OK for you?

Sure! I hope I got it right this time. :neckbeard:

PS: Thank you for the hand-holding. 🙂

@pwizla pwizla changed the title Update configuring-view-of-content-type.md Clarify sorting for relational fields in the Content Manager list view Oct 7, 2024
@pwizla
Copy link
Collaborator

pwizla commented Oct 7, 2024

Much welcome, @gurdiga!

The PR is now approved, merged, should be live on docs.strapi.io in a few minutes, and will be mentioned in the next weekly snapshot release.

@pwizla pwizla self-requested a review October 7, 2024 13:21
@pwizla pwizla added source: Dev Docs PRs/issues targeting the Developer Docs pr: fix Used on the docs repo for anything that is not "new" or "updated" content: chore, typos, fixes, etc. labels Oct 7, 2024
@pwizla pwizla added this to the 5.1.1 milestone Oct 7, 2024
@pwizla pwizla marked this pull request as ready for review October 7, 2024 13:21
@pwizla pwizla merged commit 12ececd into strapi:main Oct 7, 2024
3 checks passed
@gurdiga gurdiga deleted the patch-1 branch October 8, 2024 06:18
@pwizla pwizla added the temp: port to doc6 (Temporary label) The content of this PR should be ported to Strapi Docs v6 label Oct 14, 2024
@pwizla pwizla removed the temp: port to doc6 (Temporary label) The content of this PR should be ported to Strapi Docs v6 label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Used on the docs repo for anything that is not "new" or "updated" content: chore, typos, fixes, etc. source: Dev Docs PRs/issues targeting the Developer Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants