This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[v6] Refactor to use packet metadata instead of overloaded receiver #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor to use packet metadata instead of overloaded receiver * Bring in PacketMetadata wrapper type. Unwrap next metadata for multihop. Fix existing tests. Add multihop test * Better validation of port and channel. Use string for next memo * Pass sequence in refund transfers for multi-hop refunds * Move denom unwrapping into function and use for refund * Flip order of src/dst for ack/timeout refunds * Don't unwrap tokens for timeout/ack case * Break out inFlightPacket fetching from RefundForwardedPacket for clarity * Add debug logs * Add RefundDenom to InFlightPacket * Add more debug logs around denom. Use refund denom for ack/timeout refunds * Use non-hashed denoms on timeout/ack. If this works, we can remove RefundDenom * Parse denoms at every step * For timeout/ack, try to resolve IBC denom * Fix flipped OnRecvPacket/OnTimeout denom handling * Add more debug logs * Don't remove from store on successful ack for now * Remove RefundDenom * Don't write acknowledgements until forwarded packet returns ack. Proxy acks back to source chain. * Populate inFlightPacket * do not call upstream OnAcknowledgementPacket or OnTimeoutPacket when handling a forwarded packet response to stop refund processing. * Fix timeout retry * Burn escrowed funds or transfer to other escrow account on refund.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #36 into main