Remove UsingNewGenesisCommand config in favor of a runtime check
#759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reecepbcups
changed the title
UsingNewGenesisCommand config to instead check at runtime.UsingNewGenesisCommand config in favor of a runtime check
agouin
reviewed
Sep 8, 2023
| command = []string{"export", "--height", fmt.Sprint(height), "--home", tn.HomeDir()} | ||
| ) | ||
|
|
||
| if isNewGenesis { |
There was a problem hiding this comment.
we can keep the var here so the lookup doesn't need to be performed twice within this method
chain/cosmos/chain_node.go
Outdated
| if err != nil { | ||
| return false | ||
| } | ||
|
|
||
| return true |
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
) * ictest: remove UseNewGenesisCommand * localic: remove UseNewGenesisCommand * minor: remove needless variable * Make `IsAboveSDK47` public (cherry picked from commit cc12f99) # Conflicts: # examples/cosmos/sdk_boundary_test.go # local-interchain/go.mod # local-interchain/go.sum
Reecepbcups
added a commit
that referenced
this pull request
Sep 11, 2023
… a runtime check (#765) * Remove `UsingNewGenesisCommand` config in favor of a runtime check (#759) * ictest: remove UseNewGenesisCommand * localic: remove UseNewGenesisCommand * minor: remove needless variable * Make `IsAboveSDK47` public (cherry picked from commit cc12f99) # Conflicts: # examples/cosmos/sdk_boundary_test.go # local-interchain/go.mod # local-interchain/go.sum * Remove `UsingNewGenesisCommand` config in favor of a runtime check (#759) * ictest: remove UseNewGenesisCommand * localic: remove UseNewGenesisCommand * minor: remove needless variable * Make `IsAboveSDK47` public --------- Co-authored-by: Reece Williams <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #742
summary
Removing the config option
UsingNewGenesisCommandmakes it easier to write test spanning multiple SDK versions (v45 - 50).