Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ibc-go path to v8 #741

Merged

Conversation

colin-axner
Copy link
Contributor

Used in this branch: cosmos/ibc-go#4590

@colin-axner colin-axner requested a review from a team as a code owner September 6, 2023 15:01
@colin-axner colin-axner requested a review from boojamya September 6, 2023 15:01
@@ -7,7 +7,7 @@ import (
fmt "fmt"
_ "github.com/cosmos/gogoproto/gogoproto"
proto "github.com/cosmos/gogoproto/proto"
types "github.com/cosmos/ibc-go/v7/modules/core/02-client/types"
types "github.com/cosmos/ibc-go/v8/modules/core/02-client/types"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this needs to be regenerated. I just did a find/replace

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that it needs to, but I ususally do when I make similar PRs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @misko9 is this fine with not being regenerated for now? It will need a regen eventually in the future anyway to match the latest feat/wasm-clients branch anyway

local-interchain/go.mod Outdated Show resolved Hide resolved
@colin-axner
Copy link
Contributor Author

Hi when will this be merged? We would like to move off my fork

@Reecepbcups
Copy link
Member

Reecepbcups commented Sep 13, 2023

@colin-axner sorry for the wait! I will get this reviewed/merged now

@Reecepbcups Reecepbcups enabled auto-merge (squash) September 13, 2023 15:32
Copy link
Member

@Reecepbcups Reecepbcups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On comment: https://github.com/strangelove-ventures/interchaintest/pull/741/files#r1317429647, #747 looks like it addresses this.

@colin-axner Is the wasm client still planned for v7 or pushed back to v8? Heard this is being pushed back to IBC v8+

@Reecepbcups Reecepbcups merged commit 1ba5997 into strangelove-ventures:main Sep 13, 2023
@colin-axner colin-axner deleted the colin/module-path-bump branch September 18, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants