Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for rly v2.1.0 #295

Merged
merged 13 commits into from
Sep 20, 2022
Merged

Updates for rly v2.1.0 #295

merged 13 commits into from
Sep 20, 2022

Conversation

agouin
Copy link
Member

@agouin agouin commented Sep 16, 2022

  • Link paths in parallel to speed up tests now possible with Config file lock cosmos/relayer#987. Tests will pass once we update the go relayer DefaultContainerVersion to a release version that has this included.
  • Faucet reqs in parallel to speed up tests
  • Multiple paths same process
  • Use native denom instead of stake for delegation. Increase faucet amount.
  • Pass bech flag to KeyBech32.

@agouin agouin changed the title Parallel link Sep 16, 2022

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tvdeyen Thomas von Deyen
@agouin agouin changed the title Parallel link Updates for rly v2.1.0 Sep 16, 2022
@agouin agouin force-pushed the andrew/parallel_path_link branch from bce4efc to 695ddc4 Compare September 16, 2022 23:29
@agouin agouin changed the base branch from main to andrew/fix_conformance_race September 16, 2022 23:29
@agouin agouin marked this pull request as ready for review September 17, 2022 05:21
@agouin agouin requested a review from a team as a code owner September 17, 2022 05:21
@agouin agouin requested review from joeabbey and removed request for a team September 17, 2022 05:21
Copy link
Contributor

@DavidNix DavidNix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mention "speeding up tests" in the PR description. I'm curious what gains we saw locally and on CI?

More concurrency is not always equal to more speed.

@agouin
Copy link
Member Author

agouin commented Sep 19, 2022

You mention "speeding up tests" in the PR description. I'm curious what gains we saw locally and on CI?
More concurrency is not always equal to more speed.

For tests that need to link multiple paths before the test can proceed the savings are significant. For example, the packet forward middleware test and the Stride ICA/ICQ test.

Before (sequential synchronous path links and faucet funding):
Screenshot from 2022-09-19 09-53-32

After (parallel path links and faucet funding):
Screenshot from 2022-09-19 09-37-48

This example shows test startup overhead decreasing from 67 blocks down to 43 blocks.

@jtieri jtieri mentioned this pull request Sep 19, 2022
3 tasks
Base automatically changed from andrew/fix_conformance_race to main September 20, 2022 15:21
@agouin agouin merged commit 7653dfa into main Sep 20, 2022
@agouin agouin deleted the andrew/parallel_path_link branch September 20, 2022 15:22
agouin added a commit that referenced this pull request Sep 20, 2022
* fix race condition

* test for race conditions in CI

* fix race with FindTx and StartAllNodes

* Clone ibc.ChainConfig because of slice

* remove unnecessary change

* Fix race 3/3 for c.FullNodes/c.Validators

* fix mutex lock placement for FindTxs

* Use native denom instead of stake for delegation. Increase faucet amount. Pass bech flag to KeyBech32. faucet reqs in parallel. link paths in parallel.

* Updates for v2.1.0

* relay multiple paths same process

* use -b 100 flag

* Fix packet forward middleware test

* Add AccountKeyBech32 for default account key use case
@agouin agouin mentioned this pull request Sep 20, 2022
agouin added a commit that referenced this pull request Sep 20, 2022
* fix race condition

* test for race conditions in CI

* fix race with FindTx and StartAllNodes

* Clone ibc.ChainConfig because of slice

* remove unnecessary change

* Fix race 3/3 for c.FullNodes/c.Validators

* fix mutex lock placement for FindTxs

* Use native denom instead of stake for delegation. Increase faucet amount. Pass bech flag to KeyBech32. faucet reqs in parallel. link paths in parallel.

* Updates for v2.1.0

* relay multiple paths same process

* use -b 100 flag

* Fix packet forward middleware test

* Add AccountKeyBech32 for default account key use case
agouin added a commit that referenced this pull request Sep 20, 2022
* fix race condition

* test for race conditions in CI

* fix race with FindTx and StartAllNodes

* Clone ibc.ChainConfig because of slice

* remove unnecessary change

* Fix race 3/3 for c.FullNodes/c.Validators

* fix mutex lock placement for FindTxs

* Use native denom instead of stake for delegation. Increase faucet amount. Pass bech flag to KeyBech32. faucet reqs in parallel. link paths in parallel.

* Updates for v2.1.0

* relay multiple paths same process

* use -b 100 flag

* Fix packet forward middleware test

* Add AccountKeyBech32 for default account key use case
agouin added a commit that referenced this pull request Sep 22, 2022
* fix race condition

* test for race conditions in CI

* fix race with FindTx and StartAllNodes

* Clone ibc.ChainConfig because of slice

* remove unnecessary change

* Fix race 3/3 for c.FullNodes/c.Validators

* fix mutex lock placement for FindTxs

* Use native denom instead of stake for delegation. Increase faucet amount. Pass bech flag to KeyBech32. faucet reqs in parallel. link paths in parallel.

* Updates for v2.1.0

* relay multiple paths same process

* use -b 100 flag

* Fix packet forward middleware test

* Add AccountKeyBech32 for default account key use case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants