-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for rly v2.1.0 #295
Merged
Merged
+165
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt. Pass bech flag to KeyBech32. faucet reqs in parallel. link paths in parallel.
bce4efc
to
695ddc4
Compare
DavidNix
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mention "speeding up tests" in the PR description. I'm curious what gains we saw locally and on CI?
More concurrency is not always equal to more speed.
3 tasks
agouin
added a commit
that referenced
this pull request
Sep 20, 2022
* fix race condition * test for race conditions in CI * fix race with FindTx and StartAllNodes * Clone ibc.ChainConfig because of slice * remove unnecessary change * Fix race 3/3 for c.FullNodes/c.Validators * fix mutex lock placement for FindTxs * Use native denom instead of stake for delegation. Increase faucet amount. Pass bech flag to KeyBech32. faucet reqs in parallel. link paths in parallel. * Updates for v2.1.0 * relay multiple paths same process * use -b 100 flag * Fix packet forward middleware test * Add AccountKeyBech32 for default account key use case
Merged
agouin
added a commit
that referenced
this pull request
Sep 20, 2022
* fix race condition * test for race conditions in CI * fix race with FindTx and StartAllNodes * Clone ibc.ChainConfig because of slice * remove unnecessary change * Fix race 3/3 for c.FullNodes/c.Validators * fix mutex lock placement for FindTxs * Use native denom instead of stake for delegation. Increase faucet amount. Pass bech flag to KeyBech32. faucet reqs in parallel. link paths in parallel. * Updates for v2.1.0 * relay multiple paths same process * use -b 100 flag * Fix packet forward middleware test * Add AccountKeyBech32 for default account key use case
agouin
added a commit
that referenced
this pull request
Sep 20, 2022
* fix race condition * test for race conditions in CI * fix race with FindTx and StartAllNodes * Clone ibc.ChainConfig because of slice * remove unnecessary change * Fix race 3/3 for c.FullNodes/c.Validators * fix mutex lock placement for FindTxs * Use native denom instead of stake for delegation. Increase faucet amount. Pass bech flag to KeyBech32. faucet reqs in parallel. link paths in parallel. * Updates for v2.1.0 * relay multiple paths same process * use -b 100 flag * Fix packet forward middleware test * Add AccountKeyBech32 for default account key use case
agouin
added a commit
that referenced
this pull request
Sep 22, 2022
* fix race condition * test for race conditions in CI * fix race with FindTx and StartAllNodes * Clone ibc.ChainConfig because of slice * remove unnecessary change * Fix race 3/3 for c.FullNodes/c.Validators * fix mutex lock placement for FindTxs * Use native denom instead of stake for delegation. Increase faucet amount. Pass bech flag to KeyBech32. faucet reqs in parallel. link paths in parallel. * Updates for v2.1.0 * relay multiple paths same process * use -b 100 flag * Fix packet forward middleware test * Add AccountKeyBech32 for default account key use case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultContainerVersion
to a release version that has this included.stake
for delegation. Increase faucet amount.