[v3] Client ICQ #273
Closed
[v3] Client ICQ #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzampolin
reviewed
Sep 1, 2022
| return nil, fmt.Errorf("failed to unmarshal genesis file: %w", err) | ||
| } | ||
|
|
||
| if err := dyno.Set(g, dayEpochLen, "app_state", "epochs", "epochs", dayEpochIndex, "duration"); err != nil { |
There was a problem hiding this comment.
til dyno this is a nice way to deal with this in go
There was a problem hiding this comment.
I haven't used dyno. It seems fine for our use case.
I've also had success with http://jsoniter.com/migrate-from-go-std.html and https://github.com/Jeffail/gabs for other options if dyno ever gives us trouble.
5 tasks
agouin
force-pushed
the
andrew/client_icq
branch
from
5a26953 to
5ae726b
Compare
agouin
force-pushed
the
andrew/client_icq
branch
from
9a2f4b6 to
69b59fd
Compare
…unt. Pass bech flag to KeyBech32. faucet reqs in parallel. link paths in parallel.
…channel packets fix
agouin
force-pushed
the
andrew/client_icq
branch
from
69b59fd to
785dbde
Compare
|
Closing this as this test has been added to the relayer along with stride ICQ support cosmos/relayer#1076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.