Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format Js/css #176

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lhapaipai
Copy link
Contributor

Q A
Branch? main
Cleanup? yes
Bug fix? no
Fixed tickets
New feature? no
Doc added? no
Tests pass? yes
Deprecations? no
License MIT

Hi @COil,

this PR add the rules to homogenize the JS / CSS code with prettier.
I didn't know if you wanted a cleanup only on the css? As the tool used (Prettier) also covers the js I still included the rules for js.

Note: this requires installing node and npm on the machine so I fear that it goes against the philosophy of AssetMapper?

I separated this into 2 commits.

It's up to you to decide if you are interested or not.

Good evening

@lhapaipai

@COil COil changed the title add js/css formatter chore: js/css format Feb 22, 2025
@COil COil changed the title chore: js/css format chore: format Js/css Feb 23, 2025
@COil COil assigned COil and lhapaipai and unassigned COil Feb 23, 2025
@COil COil self-requested a review February 23, 2025 15:10
@COil COil added documentation Improvements or additions to documentation DX Developer Experience improvement improvement of an existing feature labels Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation DX Developer Experience improvement improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants