Plugins for py3 #11
Open
Plugins for py3 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There hasn't been a Python 3 release for txi2p, although it is supported in the master branch. Sadly txi2p project's original maintainers have not been available to make a new release. (See str4d#10) This is a blocker in Tahoe-LAFS project's Python 3 porting efforts, so we're making a temporary (famous last words?) fork until txi2p project's original maintainers are back.
Twisted has removed twisted.python.compat._PY3
vcversioner doesn't seem to work with modern packaging tools :/ setuptools_scm is probably approximately equivalent. Some more work probably needed there.
will have to revisit
Set up CI for tests and release automation
exarkun
force-pushed
the
plugins-for-py3
branch
from
9af450b to
78d13b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "i2p" endpoint description parser plugins are undiscoverable on Python 3 because they are defined using a txi2p-internal
IPluginon Python 3 which is not the same as the one from Twisted.This un-skips the plugin tests on Python 3 and switches to Twisted's
IPlugin.