Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unordered_map,unordered_set: Extend unit tests #77

Merged
merged 3 commits into from
Jan 11, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Jan 11, 2020

Although both unordered_map and unordered_set have probably the most extensive unit test suite, their code coverage is rather low. This is partially caused by the plethora of "read" operations to obtain certain kinds of information regarding their state. Extend the test suite to cover more of their operations and to increase the coverage.

@stotko stotko added this to the 1.2.0 milestone Jan 11, 2020
@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #77 into master will increase coverage by 5%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
+ Coverage   81.77%   86.77%   +5%     
=======================================
  Files          27       27           
  Lines        1580     1580           
=======================================
+ Hits         1292     1371   +79     
+ Misses        288      209   -79
Impacted Files Coverage Δ
src/stdgpu/impl/unordered_base_detail.cuh 88.83% <0%> (+9.89%) ⬆️
src/stdgpu/impl/unordered_map_detail.cuh 65.55% <0%> (+22.22%) ⬆️
src/stdgpu/impl/unordered_set_detail.cuh 64.77% <0%> (+22.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675da0f...1aaecdf. Read the comment docs.

@stotko stotko merged commit 75dd55c into master Jan 11, 2020
@stotko stotko deleted the unordered_map_set_tests branch January 11, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant