memory: Add safe_host_allocator and deprecate safe_pinned_host_allocator #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure is unrelated to the changes. Thus, ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The host memory allocator class called
safe_pinned_host_allocatorsuggests that memory will always be pinned. Since there is an OpenMP backend now, this does not hold anymore and is more of an implementation detail anyways. Furthermore, this is inconsistent with the device (safe_device_allocator) and managed (safe_managed_allocator) variants. Rename it tosafe_host_allocatorand keep the old version (marked as deprecated) to maintain compatibility.