Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake,src: Handle format warnings #29

Merged
merged 2 commits into from
Nov 21, 2019
Merged

cmake,src: Handle format warnings #29

merged 2 commits into from
Nov 21, 2019

Conversation

stotko
Copy link
Owner

@stotko stotko commented Nov 21, 2019

In device code, we use printf to display warnings and errors to the user. However, as indices might be 32-bit or 64-bit depending on the configuration, this may lead to warnings at compile time. Since CUDA only supports printf in device code, suppress the warnings for now.

In the future, the new std::format (C++20) will solve the issue. However, we need to wait until the support is sufficient.

@stotko stotko merged commit c13cf37 into master Nov 21, 2019
@stotko stotko deleted the format_warning branch November 21, 2019 10:48
@stotko stotko added the bug label Dec 11, 2019
@stotko stotko added this to the 1.1.0 milestone Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant