platform: Change detection of device code for OpenMP #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the OpenMP backend, the
platform
macros currently always report code to beSTDGPU_CODE_HOST
. Since someSTDGPU_HOST_DEVICE
annotated function may use different paths for host and device code and the device path may contain backend-specific optimizations, this choice will lead to backend-specific code being ignored.Change the detection code to always report
STDGPU_CODE_DEVICE
rather thanSTDGPU_CODE_HOST
. Note that for such functions using different code paths, these paths should result in equivalent behavior anyways.