bitset: Fix deprecated-copy warning #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stotko
force-pushed
the
warning_deprecrated_copy
branch
from
8635f63
to
dfbf670
Compare
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
- Coverage 97.64% 97.59% -0.06%
==========================================
Files 28 28
Lines 1698 1703 +5
==========================================
+ Hits 1658 1662 +4
- Misses 40 41 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent compilers such as GCC 10 and Clang 10 emit a stricter set of warnings. Fix the newly appearing
-Wdeprecated-copywarning by explicitly defining a copy constructor. Since ROCm's HCC compiler seems to have problems with the C++11 default version, we fallback to old C++98 style copy constructors.