Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,test: Fix hicpp-braces-around-statements warnings #132

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Apr 16, 2020

Although return statements after if clauses do not require braces, it is still useful to have them for readability reasons. Fix these clang-tidy warnings.

@stotko stotko added the bug label Apr 16, 2020
@stotko stotko added this to the 1.3.0 milestone Apr 16, 2020
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #132 into master will decrease coverage by 0.28%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   97.92%   97.63%   -0.29%     
==========================================
  Files          28       28              
  Lines        1685     1694       +9     
==========================================
+ Hits         1650     1654       +4     
- Misses         35       40       +5     
Impacted Files Coverage Δ
src/stdgpu/impl/atomic_detail.cuh 98.44% <50.00%> (-1.56%) ⬇️
src/stdgpu/impl/unordered_base_detail.cuh 96.49% <50.00%> (-0.25%) ⬇️
src/stdgpu/impl/deque_detail.cuh 93.56% <75.00%> (-0.44%) ⬇️
src/stdgpu/impl/vector_detail.cuh 93.87% <75.00%> (-0.61%) ⬇️
src/stdgpu/impl/bit_detail.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce682a4...0a79982. Read the comment docs.

@stotko stotko merged commit 9f15ec7 into master Apr 16, 2020
@stotko stotko deleted the warnings_braces_around_statements branch April 16, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant