Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples,src,test: Fix hicpp-explicit-conversion warnings #131

Merged
merged 3 commits into from
Apr 16, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Apr 16, 2020

A common pitfall are single-parameter constructors since they allow implicit conversions between classes/types. Since this behavior is usually undesired, they should be marked explicit. Fix all of these undesired cases. For the few desired ones, suppress the clang-tidy warnings.

@stotko stotko added the bug label Apr 16, 2020
@stotko stotko added this to the 1.3.0 milestone Apr 16, 2020
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files          28       28           
  Lines        1685     1685           
=======================================
  Hits         1650     1650           
  Misses         35       35           
Impacted Files Coverage Δ
src/stdgpu/bitset.cuh 100.00% <ø> (ø)
src/stdgpu/iterator.h 100.00% <ø> (ø)
src/stdgpu/mutex.cuh 100.00% <ø> (ø)
src/stdgpu/impl/deque_detail.cuh 94.00% <100.00%> (ø)
src/stdgpu/impl/iterator_detail.h 100.00% <100.00%> (ø)
src/stdgpu/impl/memory_detail.h 98.61% <100.00%> (ø)
src/stdgpu/impl/ranges_detail.h 100.00% <100.00%> (ø)
src/stdgpu/impl/unordered_base_detail.cuh 96.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7bc5fa...45f57d9. Read the comment docs.

@stotko stotko merged commit ce682a4 into master Apr 16, 2020
@stotko stotko deleted the warnings_explicit_conversions branch April 16, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant