Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix missing include in device_info cpp files #120

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Mar 23, 2020

In #118, the includes were cleaned up. During this cleanup, the device_info.cpp files were not checked properly, so the lack of a proper include to their respective header files was not discovered there. Add the respective includes such that these files also follow common conventions.

@stotko stotko added the bug label Mar 23, 2020
@stotko stotko added this to the 1.3.0 milestone Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #120 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   97.81%   97.87%   +0.06%     
==========================================
  Files          27       27              
  Lines        1648     1648              
==========================================
+ Hits         1612     1613       +1     
+ Misses         36       35       -1     
Impacted Files Coverage Δ
src/stdgpu/impl/unordered_base_detail.cuh 96.73% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5ab25...a6b3ab6. Read the comment docs.

@stotko stotko merged commit 1e9063a into master Mar 23, 2020
@stotko stotko deleted the device_info_include branch March 23, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant