CI: Fix codecov task #113
Merged
CI: Fix codecov task #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 27 27
Lines 1648 1648
=======================================
Hits 1613 1613
Misses 35 35Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the codecov task defined in the Azure Pipelines CI YAML file silently failed since something regarding the upload token seems to have changed for pull requests. Independently of being a potential regression in Azure Pipelines CI or codecov CI, this issue can be addressed on our side by explicitly passing the upload token to the upload script. This makes the CI task more robust. In addition to that, also tell the upload script to return failure (i.e. 1) if the uploading process failed.