-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing button titles #6124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aamct2
requested review from
Hypnosphi,
igor-dv,
ndelangen and
tmeasday
as code owners
March 16, 2019 13:47
Armanio
added
ui
accessibility
patch:yes
Bugfix & documentation PR that need to be picked to main branch
labels
Mar 16, 2019
Codecov Report
@@ Coverage Diff @@
## next #6124 +/- ##
=========================================
- Coverage 38.07% 37.57% -0.5%
=========================================
Files 643 643
Lines 9414 9407 -7
Branches 1370 1341 -29
=========================================
- Hits 3584 3535 -49
- Misses 5265 5307 +42
Partials 565 565
Continue to review full report at Codecov.
|
Thanks! |
shilman
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
bug
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
ui
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6123
What I did
How to test
Run any of the examples and inspect the adjusted buttons to see that they now have a
title
attribute specified. These issues can also be picked up by Lighthouse in the Accessibility audit in the Chrome Developer Tools.