Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing button titles #6124

Merged
merged 2 commits into from
Mar 16, 2019
Merged

Conversation

aamct2
Copy link
Contributor

@aamct2 aamct2 commented Mar 16, 2019

Issue: #6123

What I did

How to test

Run any of the examples and inspect the adjusted buttons to see that they now have a title attribute specified. These issues can also be picked up by Lighthouse in the Accessibility audit in the Chrome Developer Tools.

@Armanio Armanio added ui accessibility patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 16, 2019
@Armanio
Copy link
Member

Armanio commented Mar 16, 2019

Good job @aamct2
One notice: when you update UI you must regenerate snapshots for test passes.
More information you can read here.
When the snapshots will be updated i will merge PR.
Could you update the snapshots?

@codecov
Copy link

codecov bot commented Mar 16, 2019

Codecov Report

Merging #6124 into next will decrease coverage by 0.49%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next    #6124     +/-   ##
=========================================
- Coverage   38.07%   37.57%   -0.5%     
=========================================
  Files         643      643             
  Lines        9414     9407      -7     
  Branches     1370     1341     -29     
=========================================
- Hits         3584     3535     -49     
- Misses       5265     5307     +42     
  Partials      565      565
Impacted Files Coverage Δ
lib/ui/src/components/sidebar/SidebarSearch.js 63.63% <ø> (ø) ⬆️
lib/ui/src/components/sidebar/SidebarHeading.js 88.88% <ø> (ø) ⬆️
lib/ui/src/components/preview/preview.js 86.44% <50%> (-1.5%) ⬇️
addons/cssresources/src/constants.ts 0% <0%> (-100%) ⬇️
addons/cssresources/src/css-resource-panel.tsx 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7f0e23...4c05eac. Read the comment docs.

@storybookjs storybookjs deleted a comment from github-actions bot Mar 16, 2019
@Armanio
Copy link
Member

Armanio commented Mar 16, 2019

Thanks!

@Armanio Armanio merged commit 949aca7 into storybookjs:next Mar 16, 2019
@shilman shilman added the bug label Mar 17, 2019
@aamct2 aamct2 mentioned this pull request Mar 17, 2019
3 tasks
@aamct2 aamct2 deleted the fix-missing-button-titles branch March 17, 2019 08:37
shilman pushed a commit that referenced this pull request Mar 18, 2019
shilman pushed a commit that referenced this pull request Mar 23, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants