Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing button titles #6124

Merged
merged 2 commits into from
Mar 16, 2019
Merged

Add missing button titles #6124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
176e6a1
Add missing button titles
aamct2 Mar 16, 2019
4c05eac
Update jest snapshots
aamct2 Mar 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions examples/official-storybook/tests/__snapshots__/storyshots.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8446,6 +8446,7 @@ exports[`Storyshots UI|Sidebar/Sidebar loading 1`] = `
>
<button
class="emotion-5"
title="Shortcuts"
>
<svg
class="emotion-4"
Expand Down Expand Up @@ -9872,6 +9873,7 @@ exports[`Storyshots UI|Sidebar/Sidebar simple 1`] = `
>
<button
class="emotion-5"
title="Shortcuts"
>
<svg
class="emotion-4"
Expand Down Expand Up @@ -9909,6 +9911,7 @@ exports[`Storyshots UI|Sidebar/Sidebar simple 1`] = `
</svg>
<button
class="emotion-13"
title="Clear search"
type="reset"
value="reset"
>
Expand Down Expand Up @@ -10412,6 +10415,7 @@ exports[`Storyshots UI|Sidebar/SidebarHeading customBrandImage 1`] = `
>
<button
class="emotion-5"
title="Shortcuts"
>
<svg
class="emotion-4"
Expand Down Expand Up @@ -10709,6 +10713,7 @@ exports[`Storyshots UI|Sidebar/SidebarHeading linkAndText 1`] = `
>
<button
class="emotion-4"
title="Shortcuts"
>
<svg
class="emotion-3"
Expand Down Expand Up @@ -10986,6 +10991,7 @@ exports[`Storyshots UI|Sidebar/SidebarHeading longText 1`] = `
>
<button
class="emotion-3"
title="Shortcuts"
>
<svg
class="emotion-2"
Expand Down Expand Up @@ -11362,6 +11368,7 @@ exports[`Storyshots UI|Sidebar/SidebarHeading menuHighlighted 1`] = `
>
<button
class="emotion-5"
title="Shortcuts"
>
<svg
class="emotion-4"
Expand Down Expand Up @@ -11639,6 +11646,7 @@ exports[`Storyshots UI|Sidebar/SidebarHeading onlyText 1`] = `
>
<button
class="emotion-3"
title="Shortcuts"
>
<svg
class="emotion-2"
Expand Down Expand Up @@ -11993,6 +12001,7 @@ exports[`Storyshots UI|Sidebar/SidebarHeading standard 1`] = `
>
<button
class="emotion-5"
title="Shortcuts"
>
<svg
class="emotion-4"
Expand Down Expand Up @@ -12327,6 +12336,7 @@ exports[`Storyshots UI|Sidebar/SidebarHeading standardNoLink 1`] = `
>
<button
class="emotion-4"
title="Shortcuts"
>
<svg
class="emotion-3"
Expand Down Expand Up @@ -14245,6 +14255,7 @@ exports[`Storyshots UI|Sidebar/SidebarSearch filledIn 1`] = `
</svg>
<button
class="emotion-5"
title="Clear search"
type="reset"
value="reset"
>
Expand Down Expand Up @@ -14533,6 +14544,7 @@ exports[`Storyshots UI|Sidebar/SidebarSearch focussed 1`] = `
</svg>
<button
class="emotion-5"
title="Clear search"
type="reset"
value="reset"
>
Expand Down Expand Up @@ -14821,6 +14833,7 @@ exports[`Storyshots UI|Sidebar/SidebarSearch simple 1`] = `
</svg>
<button
class="emotion-5"
title="Clear search"
type="reset"
value="reset"
>
Expand Down Expand Up @@ -16510,6 +16523,7 @@ exports[`Storyshots UI|Sidebar/SidebarStories noRoot 1`] = `
</svg>
<button
class="emotion-5"
title="Clear search"
type="reset"
value="reset"
>
Expand Down Expand Up @@ -17425,6 +17439,7 @@ exports[`Storyshots UI|Sidebar/SidebarStories withRoot 1`] = `
</svg>
<button
class="emotion-5"
title="Clear search"
type="reset"
value="reset"
>
Expand Down
2 changes: 2 additions & 0 deletions lib/ui/src/components/preview/__snapshots__/preview.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ Array [
</span>
<button
class="emotion-2"
title="Open canvas in new tab"
>
<svg
class="emotion-1"
Expand Down Expand Up @@ -731,6 +732,7 @@ Array [
</span>
<button
class="emotion-8"
title="Open canvas in new tab"
>
<svg
class="emotion-7"
Expand Down
6 changes: 5 additions & 1 deletion lib/ui/src/components/preview/preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,11 @@ const getTools = memoize(10)(
{
match: p => p.viewMode === 'story',
render: () => (
<IconButton key="opener" onClick={() => window.open(`${baseUrl}?id=${storyId}`)}>
<IconButton
key="opener"
onClick={() => window.open(`${baseUrl}?id=${storyId}`)}
title="Open canvas in new tab"
>
<Icons icon="share" />
</IconButton>
),
Expand Down
2 changes: 1 addition & 1 deletion lib/ui/src/components/sidebar/SidebarHeading.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ const SidebarHeading = withState('tooltipShown', 'onVisibilityChange', false)(
}
closeOnClick
>
<MenuButton outline small containsIcon highlighted={menuHighlighted}>
<MenuButton outline small containsIcon highlighted={menuHighlighted} title="Shortcuts">
<Icons icon="ellipsis" />
</MenuButton>
</WithTooltip>
Expand Down
2 changes: 1 addition & 1 deletion lib/ui/src/components/sidebar/SidebarSearch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export const PureSidebarSearch = ({ focussed, onSetFocussed, className, onChange
placeholder={focussed ? 'Type to search...' : 'Press "/" to search...'}
/>
<Icons icon="search" />
<CancelButton type="reset" value="reset">
<CancelButton type="reset" value="reset" title="Clear search">
<Icons icon="closeAlt" />
</CancelButton>
</FilterForm>
Expand Down