-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show active viewport dimensions & button to rotate #6045
Show active viewport dimensions & button to rotate #6045
Conversation
If i click the rotate button, the button keeps being highlighted until i click somewhere else. Additional feature wishes:
|
@lucas-carl This is awesome. Could use some visual treatment (cc @domyen) but we can do that before the 5.1 release. Great work! Are you up for tackling any of the improvements suggested by @backbone87? |
@shilman @backbone87 I will try to implement these suggestions. |
Codecov Report
@@ Coverage Diff @@
## next #6045 +/- ##
=========================================
- Coverage 35.78% 34.89% -0.9%
=========================================
Files 648 648
Lines 9520 9503 -17
Branches 1380 1337 -43
=========================================
- Hits 3407 3316 -91
- Misses 5536 5553 +17
- Partials 577 634 +57
Continue to review full report at Codecov.
|
sadly
is missing |
Issue: #5879
What I did