-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewport addon not working as expected #6392
Comments
Have you taken a look at our example? Does this work as expected on your machine/browser? https://storybooks-official.netlify.com/?path=/story/ui-panel--default |
Yes it does. I cloned the repo and will test the example to see if I find any difference between my setup and what the example does. |
@shilman, I'm definitely seeing an issue similar to this in next. Example can be found here: https://next--storybooks-vue.netlify.com/?path=/story/welcome--welcome |
It looks like this is a problem in @lucas-carl mind taking a look at this? |
@shilman I looked into the next version right after my PR but can't seem to find any bugs. |
Having the same issue. |
Seeing this issue with |
Same here, broken on @next |
@lucas-carl Indeed, I checked and the problem got introduced in @Armanio mind looking into this? |
I'll check it today. Give me a few hours. 👍 |
Guys, I apologize: it's my mistake, I fixed zoom and broke background addon. |
Just tested and it is working just fine. Thank you guys :) |
w00t!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.26 containing PR #6502 that references this issue. Upgrade today to try it out! Because it's a pre-release you can find it on the |
Describe the bug
After registering the addon it's icon shows up in the storybook window but the behavior is odd. Whenever I try to chose a viewport I end up with the same thing.
To Reproduce
Steps to reproduce the behavior:
yarn add -D @storybook/addon-viewport
addons.js
Expected behavior
The viewport setting resizes the viewport as shown in the print in the Readme.
Actual behavior
With no breakpoints selected (this is correct)
With any breakpoint selected (in this case, iphone6)
Notice that it changes the size of the viewport (see scrollbar on the right) but not to the expected size.
System:
The text was updated successfully, but these errors were encountered: