Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REMOVE previously deprecated default export from backgrounds #5828

Merged
merged 6 commits into from
Mar 4, 2019
Merged

REMOVE previously deprecated default export from backgrounds #5828

merged 6 commits into from
Mar 4, 2019

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Mar 4, 2019

Issue: #5818

What I did

  • Made the old withBackgrounds not throw an error but do nothing and log a deprecation warning.

  • Updated the migration guide with info.

Tom Coleman added 2 commits March 4, 2019 11:47
REMOVE previously deprecated default export from backgrounds
a7a5ae3
FIX: a bit of cleanup for backgrounds.
0d4c21c 
Didn't change any supported behaviour, but this should help with users migrating. #5818
@vercel
Copy link

vercel bot commented Mar 4, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@tmeasday tmeasday added this to the v5.0.0 milestone Mar 4, 2019
shilman
shilman approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 4, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (next@112b9f4). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5828   +/-   ##
=======================================
  Coverage        ?   34.36%           
=======================================
  Files           ?      648           
  Lines           ?     9452           
  Branches        ?     1340           
=======================================
  Hits            ?     3248           
  Misses          ?     5590           
  Partials        ?      614
Impacted Files Coverage Δ
addons/backgrounds/src/constants.ts 0% <ø> (ø)
addons/backgrounds/src/index.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112b9f4...7051627. Read the comment docs.

@vercel vercel bot requested a deployment to staging March 4, 2019 02:49 Abandoned
@vercel vercel bot requested a deployment to staging March 4, 2019 02:51 Abandoned
shilman
shilman approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🙇

@shilman shilman merged commit 51be1fc into next Mar 4, 2019
@shilman shilman deleted the 5818-cleanup-backgrounds branch March 4, 2019 02:52
shilman added a commit that referenced this pull request Mar 4, 2019
@shilman
Merge pull request #5828 from storybooks/5818-cleanup-backgrounds
bceef46 
REMOVE previously deprecated default export from backgrounds
@shilman shilman mentioned this pull request Mar 4, 2019
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
addon: backgrounds documentation patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman