Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try, catch for IE11 as it breaks script execution #4870

Merged
merged 2 commits into from
Nov 27, 2018

Conversation

hmelenok
Copy link
Contributor

Issue:
More details - #4854, IE11 breaks on change url with security error

What I did

Add try/catch for this case

How to test

Try to load

  • Is this testable with Jest or Chromatic screenshots? - I think not
  • Does this need a new example in the kitchen sink apps? - Nope
  • Does this need an update to the documentation? - I not sure about that

@hmelenok hmelenok changed the title Add try,catch for IE11 as it breaks script execution Add try, catch for IE11 as it breaks script execution Nov 27, 2018
@ndelangen
Copy link
Member

IE11 doesn't support the history api?!
I really thought it did!

@ndelangen ndelangen self-assigned this Nov 27, 2018
@ndelangen ndelangen added the bug label Nov 27, 2018
@ndelangen ndelangen added this to the next milestone Nov 27, 2018
@ndelangen
Copy link
Member

OK, so something is causing a security issue in IE11, would be nice to actually prevent the security issue, but meanwhile merging this can do no harm 👌

@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #4870 into next will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #4870      +/-   ##
==========================================
+ Coverage   35.23%   35.24%   +<.01%     
==========================================
  Files         564      564              
  Lines        6924     6925       +1     
  Branches      929      929              
==========================================
+ Hits         2440     2441       +1     
  Misses       3992     3992              
  Partials      492      492
Impacted Files Coverage Δ
lib/ui/src/modules/ui/configs/handle_routing.js 61.53% <100%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f5b39...c73b7c6. Read the comment docs.

@ndelangen ndelangen merged commit 50bba13 into storybookjs:next Nov 27, 2018
@ndelangen
Copy link
Member

Thank you @hmelenok !

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Nov 28, 2018
shilman pushed a commit that referenced this pull request Dec 3, 2018
Add try, catch for IE11 as it breaks script execution
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants