Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 Side panel not renders, fail with SecurityError #4854

Closed
hmelenok opened this issue Nov 26, 2018 · 1 comment
Closed

IE11 Side panel not renders, fail with SecurityError #4854

hmelenok opened this issue Nov 26, 2018 · 1 comment

Comments

@hmelenok
Copy link
Contributor

Describe the bug
Side panel is empty:
screen shot 2018-11-26 at 12 57 03

In attempt go to component directly (copy link in other than IE11 browser) throws SecurityError which pointing to https://github.com/storybooks/storybook/blob/master/lib/ui/src/modules/ui/configs/handle_routing.js#L51 (there no try/catch)

screen shot 2018-11-26 at 12 58 20

screen shot 2018-11-26 at 12 58 57

screen shot 2018-11-26 at 12 59 10

To Reproduce
Steps to reproduce the behavior:

  1. Go to Root of statically exported in IE11
  2. Observe no sidebar items

OR

  1. Go to directly at any component path
  2. Observe no sidebar items

OR

  1. Search in component input
  2. Observe no sidebar items
  3. Error in console

screen shot 2018-11-26 at 14 01 38

Expected behavior
There should be items in sidebar, search by components should work

Code snippets
package.json versions:

  "@storybook/addon-actions": "4.0.9",
    "@storybook/addon-console": "1.1.0",
    "@storybook/addon-info": "4.0.9",
    "@storybook/addon-knobs": "4.0.9",
    "@storybook/addon-links": "4.0.9",
    "@storybook/addon-options": "4.0.8",
    "@storybook/addon-storyshots": "4.0.9",
    "@storybook/addons": "4.0.9",
    "@storybook/react": "4.0.9",

Addons:

import '@storybook/addon-knobs/register';
import '@storybook/addon-actions/register';
import '@storybook/addon-links/register';
import '@storybook/addon-options/register';

Config:

import '@babel/polyfill';
import {configure, addDecorator} from '@storybook/react';
import '@storybook/addon-console';
import {withOptions} from '@storybook/addon-options';
import {withInfo} from '@storybook/addon-info';
import colors from '@shelf/client-helpers/lib/colors';
import TableComponent from './InfoTableComponent';

const {$orangish} = colors;

addDecorator(
  withOptions({
    name: 'Shelf React Components',
    url: 'https://shelf.io',
    hierarchySeparator: '\\->',
    addonPanelInRight: false
  })
);
// automatically import all files ending in *.stories.js
const req = require.context('../stories', true, /.stories.js$/);

function loadStories() {
  req.keys().forEach(filename => req(filename));
}

/** This overrides default withInfo options */
const withInfoDefaultOptions = {
  inline: true,
  styles: {
    header: {
      h1: {
        color: $orangish
      }
    },
    infoBody: {
      padding: '20px'
    },
    infoStory: {
      marginTop: '30px',
      marginBottom: '30px',
      border: '1px solid #eee',
      padding: '20px',
      borderRadius: '2px'
    },
    propTableHead: {
      margin: '20px 0 5px 0'
    }
  },
  TableComponent
};

addDecorator(withInfo(withInfoDefaultOptions));
configure(loadStories, module);

System:

  • OS: Windows 10
  • Device: Macbook 13inch Mid 2015
  • Browser: IE11
  • Framework: React
  • Addons: knobs/links/actions/options/console
  • Version: [4.0.9]
@hmelenok
Copy link
Contributor Author

hmelenok commented Dec 2, 2018

Fixed with new alpha 🎉

@igor-dv igor-dv closed this as completed Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants